-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Guzzle stream to download files from GDrive #21732
Conversation
The API library does not support streaming and always reads the full file into memory. This workaround copies the signed headers to a Guzzle request and returns the response as stream.
By analyzing the blame information on this pull request, we identified @Xenopathic, @MTGap and @icewind1991 to be potential reviewers |
nice 👍 |
Looks good 👍 |
@karlitschek backport to 8.2.2 at least ? |
backport is fine if this is fully tested. 👍 |
@davitol mind doing another test for this PR ? The only test needed is downloading, see original post. Maybe spice it up a bit with encryption and shares 😄 |
Use Guzzle stream to download files from GDrive
stable8.2: #21825 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The API library does not support streaming and always reads the full
file into memory.
This workaround copies the signed headers to a Guzzle request and
returns the response as stream.
Inspired by @icewind1991's approach for DAV: #18653
Before: (the download takes a while to start due to temp storage)
After:
Fixes the download part of #21357
Please review @icewind1991 @Xenopathic