[stable8.2] Use Guzzle stream to download files from GDrive #21825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API library does not support streaming and always reads the full file into memory. This workaround copies the signed headers to a Guzzle request and returns the response as stream.
|
By analyzing the blame information on this pull request, we identified @Xenopathic, @MTGap and @icewind1991 to be potential reviewers |
|
👎 - breaks with encryption enabled |
|
This used to cause issues with encryption due to packet size problems (fread doesn't return the expected number of bytes by design, a PHP thing with streams), see #22590 To be on the safe side, let's close this backport. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21732 to stable8.2
@davitol can you help testing this ? The only affected part is downloads, they should be faster.
See #21732 (comment)
Might be a good idea to also test with encryption enabled and with shares.