Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]configure custom translation for tests #10135

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Sep 23, 2024

Description

Cofigure custom translation for tests. Translations are used for activities, antivirus and notifications tests.

To configure the custom translation use the env OCIS_TRANSLATION_PATH which takes the path to the base folder where the translation file exists. Currently the translation files exists in tests/config/translations folder.
OCIS_TRANSLATION_PATH=tests/config/translations

Docs:

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Sep 23, 2024
@PrajwolAmatya PrajwolAmatya force-pushed the fix-activities-test branch 8 times, most recently from 8c8fec7 to ced1bd8 Compare September 25, 2024 10:01
@mmattel
Copy link
Contributor

mmattel commented Sep 26, 2024

@PrajwolAmatya dont know if this is important, but OCIS_TRANSLATION_PATH is (currently) present in 4 services which are: notifications, userlog, graph and activitylog as they all have server sided translations. (antivirus, as written in the chat is not part of that list).

If you think that we need some dev docs addon in translations because of CI and things that need to be considered when developing, feel free to add some text (better safe than sorry...).

@PrajwolAmatya PrajwolAmatya force-pushed the fix-activities-test branch 3 times, most recently from 49537e9 to f40ca63 Compare October 1, 2024 04:28
.drone.star Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 2, 2024

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit 0dc9811 into master Oct 2, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Oct 2, 2024
[tests-only][full-ci]configure custom translation for tests
@saw-jan saw-jan deleted the fix-activities-test branch October 2, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly failure at apiActivities
3 participants