Move phpunit.xml to root folder

[phil-davis]

• Put phpunit.xml into the root folder of the app.
• Put the coverage report into tests/output/clover.xml
• Use the phpunit from core
• Remove excess items from require-dev of composer.json

[phil-davis]

@PVince81 @DeepDiver1975 this seems to be what has been done in other apps.

Is this the current "standard"?

If so, then we can easily adjust other apps the same way.

[codecov]

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     72.83%   72.83%           
  Complexity      225      225           
=========================================
  Files            25       25           
  Lines           968      968           
=========================================
  Hits            705      705           
  Misses          263      263

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1098a21...2439a7c. Read the comment docs.

[phil-davis]

@DeepDiver1975 please review and approve, assuming your thumbs-up above means you are happy.

[phil-davis]

@DeepDiver1975 @patrickjahns @PVince81 this is ready for review again.
I got rid of the local phpunit and it uses phpunit from core, in the same way that data_exporter is doing.

[phil-davis]

This makes the CI infrastructure in this app more like "the imagined standard".
It implements stuff like what is already in data_exporter

@patrickjahns this one will be easier to review (smaller) than the files_antivirus one. So it might be good to get this agreed and merged first. Then we just check that owncloud/files_antivirus#273 implements things the same way.

[paurakhsharma]

when we have vendor/ in .gitignore file, do we really need vendor-bin/**/vendor

[phil-davis]

vendor/ will just ignore the directory vendor at the top level of the repo.
The other one is inside vendor-bin/ which is a different top-level directory.
Edit: see comments below

[paurakhsharma]

@phil-davis, IMO if we add /vendor it will only ignore the top-level directory. But in this case (i.e when using vendor/) every vendor folder inside the repo is ignored.

[phil-davis]

I tested this just now. What @paurakhsharma says is true. Every folder called vendor anywhere in the tree is ignored just by writing vendor/ in .gitignore

@patrickjahns please advise what you want to do. Because we need to have a consistent format for this stuff in every repo. Otherwise it is confusing for people who wonder about small differences.