Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permissions and expiration date for public share #120

Closed
wants to merge 1 commit into from
Closed

Add permissions and expiration date for public share #120

wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Fixes #119
@SergioBertolinSG

But requires expirationDate to be settable by core.

Also:

  • TODO: add test for update_share with expiration date

@PVince81
Copy link
Contributor Author

requested in core: owncloud/core#18631 (comment)

@PVince81 PVince81 mentioned this pull request Aug 29, 2015
Merged
1 task
@PVince81 PVince81 force-pushed the publicshare-additionalattrs branch from bbf79ef to 9c53dec Compare August 29, 2015 15:00
@PVince81
Copy link
Contributor Author

  • TODO: unit tests need a fallback for OC < 8.2 where expireDate could not be set, but we still want the tests to pass

@PVince81 PVince81 force-pushed the publicshare-additionalattrs branch 2 times, most recently from 4c3eaef to 2d8b42e Compare September 1, 2015 08:39
@PVince81 PVince81 force-pushed the publicshare-additionalattrs branch from 2d8b42e to a68cbcf Compare October 13, 2015 09:15
@PVince81 PVince81 mentioned this pull request Dec 18, 2015
Open
@PVince81 PVince81 force-pushed the publicshare-additionalattrs branch from 16aa340 to 63aed10 Compare December 18, 2015 10:11
@PVince81
Copy link
Contributor Author

Rebased.

Will still need the unit tests to be version conditional...

@SergioBertolinSG
Copy link
Contributor

This PR now needs a lot of changes, I guess it is better to prepare a new one for being used with current master structure.

@SergioBertolinSG SergioBertolinSG mentioned this pull request Dec 23, 2015
Open
@SergioBertolinSG
Copy link
Contributor

I've opened a follow up PR taking into account the new structure using shareinfo. #143

@PVince81 PVince81 closed this Dec 23, 2015
@PVince81 PVince81 deleted the publicshare-additionalattrs branch December 23, 2015 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PVince81 @SergioBertolinSG