Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapted PR 120 to new structure #143

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adapted PR 120 to new structure #143

wants to merge 5 commits into from

Conversation

SergioBertolinSG
Copy link
Contributor

Follow up of #120

It adds the expiration date support.

@PVince81 Please review.

@SergioBertolinSG SergioBertolinSG mentioned this pull request Dec 23, 2015
Closed
1 task
@SergioBertolinSG
Copy link
Contributor Author

It still has the problem of not being compatible with <8.2 versions.

@PVince81
Copy link
Contributor

Thanks, then maybe leave it for 0.3

@PVince81 PVince81 added this to the 0.3 milestone Dec 23, 2015
@SergioBertolinSG
Copy link
Contributor Author

This has to wait until #144 is merged.
A version of the failing test in version <8.2 should be added and a condition in owncloud/test/test.py to run one or another depending on the server version.

@PVince81
Copy link
Contributor

@SergioBertolinSG already merged 😉

@SergioBertolinSG
Copy link
Contributor Author

Currently failing because self variable cannot be accessed.

This seems to be the path to follow:
http://stackoverflow.com/questions/14768135/how-to-fail-a-python-unittest-in-setupclass

@SergioBertolinSG
Copy link
Contributor Author

@PVince81 please review.

PVince81
PVince81 reviewed Jan 7, 2016
View reviewed changes
owncloud/test/test.py
current_version_major = current_version[0]
current_version_minor = current_version[1]
if ((current_version_major >= '8') and (current_version_minor >= '2')):
raise unittest.SkipTest("This test should not run against >=8.2 servers");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean "This test should not run against < 8.2 servers" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that string is correct, which is not correct is the logic, it should check the major before, I'll change it.

@SergioBertolinSG SergioBertolinSG mentioned this pull request May 25, 2016
Closed
@PVince81 PVince81 modified the milestones: 0.3, 0.5 Jan 26, 2017
@PVince81
Copy link
Contributor

Conflicts.

Also I think we can stop support 8.1 as it's EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioBertolinSG @PVince81