Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Added acceptance tests for user:sync command with super/sub-strings in user usernames #508

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Feb 6, 2020

Description

Acceptance tests added for user:sync command covering:

  • sync a user that is a substring of some other LDAP user
  • sync a user that is a substring and superstring of some local user

Related Issue

owncloud/core#36597
owncloud/core#33293

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kiranparajuli589 kiranparajuli589 changed the title [Tests-Only] added acceptance tests for user:sync command including super/sub-stri… [Tests-Only] Added acceptance tests for user:sync command with super/sub-strings in user usernames Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #508 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #508   +/-   ##
=========================================
  Coverage     35.95%   35.95%           
  Complexity     1332     1332           
=========================================
  Files            31       31           
  Lines          3780     3780           
=========================================
  Hits           1359     1359           
  Misses         2421     2421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50b486...a8649df. Read the comment docs.

@kiranparajuli589 kiranparajuli589 force-pushed the usersync-super/sub-string branch from b26f152 to 50352a5 Compare February 6, 2020 07:16
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review February 10, 2020 03:19
@kiranparajuli589 kiranparajuli589 force-pushed the usersync-super/sub-string branch from 50352a5 to 711663e Compare February 10, 2020 03:20
@phil-davis
Copy link
Contributor

@kiranparajuli589 before pushing changes, you can wait for the other PR to get merged.
There will be conflicts to resolve anyway, after that.

@kiranparajuli589 kiranparajuli589 force-pushed the usersync-super/sub-string branch from 711663e to a8649df Compare February 11, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants