Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clickhouse policy to the db #6862

Merged
merged 17 commits into from
Oct 17, 2024
Merged

Add clickhouse policy to the db #6862

merged 17 commits into from
Oct 17, 2024

Conversation

andrewjstone
Copy link
Contributor

@andrewjstone andrewjstone commented Oct 14, 2024

This enables us to enable and disable both clickhouse clusters and single-node clickhouse zones.

We anticipate few changes to this policy and so we maintain a complete history indexed by version. We only allow updates via a single version increment, and we guarantee consistency by ensuring the previous version is the latest version in the database while updating.

@andrewjstone andrewjstone changed the title Add policy to the db Add clickhouse policy to the db Oct 16, 2024
@andrewjstone andrewjstone marked this pull request as ready for review October 16, 2024 18:17
Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, basically all nitpicks.

Should this PR update PlanningInputFromDb to read this table?

nexus/db-queries/src/db/datastore/clickhouse_policy.rs Outdated Show resolved Hide resolved
nexus/db-queries/src/db/datastore/clickhouse_policy.rs Outdated Show resolved Hide resolved
nexus/types/src/deployment/planning_input.rs Outdated Show resolved Hide resolved
nexus/types/src/deployment/planning_input.rs Outdated Show resolved Hide resolved
nexus/types/src/deployment/planning_input.rs Outdated Show resolved Hide resolved
@andrewjstone
Copy link
Contributor Author

Should this PR update PlanningInputFromDb to read this table?

Yes. Yes it should! Thanks for the reminder.

@andrewjstone
Copy link
Contributor Author

Should this PR update PlanningInputFromDb to read this table?

Yes. Yes it should! Thanks for the reminder.

Done in add2874

@andrewjstone andrewjstone merged commit 8d899ca into main Oct 17, 2024
16 checks passed
@andrewjstone andrewjstone deleted the clickhouse-policy-2 branch October 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants