Bodhi update fixes #2596
Merged
Bodhi update fixes #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 11s |
mfocko
approved these changes
Oct 24, 2024
| cls, | ||
| koji_nvrs: str, | ||
| ) -> set["BodhiUpdateTargetModel"]: | ||
| regexp = "|".join(re.escape(nvr) for nvr in set(koji_nvrs.split())) |
| session.query(BodhiUpdateTargetModel) | ||
| .filter( | ||
| BodhiUpdateTargetModel.status.in_(("queued", "retry", "success")), | ||
| BodhiUpdateTargetModel.koji_nvrs.regexp_match(regexp).compile( |
There was a problem hiding this comment.
Not sure, I followed an example from the documentation.
Signed-off-by: Nikola Forró <[email protected]>
…date Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 17s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 05s |
softwarefactory-project-zuul
bot
merged commit 23bc167
into
packit:main
4 checks passed
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
Nov 4, 2024
…2609) Make sure `bodhi_update` job runs don't get stuck in `queued` state When an unhandled exception occurs, a Sentry issue is created but the job run stays in queued state, which breaks the condition that is supposed to prevent submitting the same update more than once, as it considers that job run to be in progress. Make sure the state is updated when that happens. Question is, in such case should the exception and traceback be stored and issue with it created in the issue repository or do we consider that internal? Related to #2596. Reviewed-by: Matej Focko Reviewed-by: Laura Barcziová Reviewed-by: Nikola Forró
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2573.