Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] i18n messages files fix #4611

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Oct 8, 2024

Why am I making these changes?

So apparently Pontoon has this special behavior where it expects any files containing the word messages to have a specific kind of json pattern.

So instead of adapting to that I just decided to rename those files. Since we don't want to change their namespaces i had to add them to namespace->file matcher.

What are the changes from a developer perspective?

Make sure that the namespaces for *messages get matched to the correctly renamed files

How to test the changes?

Run the game
see if the renamed files are loaded properly so no i18n strings are missing.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@flx-sta flx-sta marked this pull request as ready for review October 8, 2024 17:03
@flx-sta flx-sta requested a review from a team as a code owner October 8, 2024 17:03
@Tempo-anon Tempo-anon merged commit 39cebb7 into pagefaultgames:beta Oct 8, 2024
13 checks passed
@flx-sta flx-sta deleted the bug/i18n-messages branch October 8, 2024 17:31
flx-sta added a commit to flx-sta/pokerogue that referenced this pull request Oct 8, 2024
Tempo-anon pushed a commit that referenced this pull request Oct 8, 2024
… `mystery-encounter-messages` -> `mystery-encounter-texts` (#4617)

Something I missed in #4611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants