[Ability] Implement Mirror Armor

[PrabbyDD]

Should be working now, and passes all test

When magic bounce is implemented, should probably add a test for how mirror armor interacts with magic bounce, but
I feel like how its implemented now should be fine, since magic bounce shouldnt reflect stat moves directly, rather status moves (some of which are stat moves). But still a test should be made.

What are the changes the user will see?

Mirror Armor will work as intended in the game

Why am I making these changes?

Adding new gameplay features

What are the changes from a developer perspective?

Added several variables to keep track of which pokemon used certain moves or abilities so mirror armor can properly
target

Added a new ability attr

changed certain phase files to implement this behavior,

I dont really like using all these extra variables and tried to keep the additions to a minimum, but I just couldnt find enough
tools to do what I needed to do so I had to hard code in some of these variables to make the ability work.

Screenshots/Videos

Video 1

2024-11-19.13-20-40.mp4

Video 2

2024-11-19.13-19-58.mp4

Video 3

2024-11-19.13-19-03.mp4

Video 4

2024-11-19.13-17-21.mp4

Video 5

2024-11-19.13-00-22.mp4

Video 6

2024-11-19.13-04-07.mp4

Video 7

2024-11-19.13-04-53.mp4

Video 8

2024-11-19.13-05-39.mp4

Video 9

2024-11-19.13-06-20.mp4

Video 10

2024-11-19.13-07-30.mp4

Video 11

2024-11-19.13-08-09.mp4

How to test the changes?

Override Files and unit tests, and debugger in browser

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[PrabbyDD]

I would also like if someone updated the ability draft with this PR as well...I dont think I can. Thanks :)

[DayKev]

For ArenaTags, they should have a sourceId field that contains the ID of the pokemon that set it. If that's not viable for whatever reason, you should be able to add a field to the class used by Sticky Webs etc to store the necessary information instead.

[PrabbyDD]

I changed the code to use the source ID field from arena tag. I dont know why there is an issue with public/locales in this repo - and I am not sure how to fix it. I dont think I touched public/locales in this branch.

[DayKev]

Try running git submodule update --progress --init --recursive, then commit and push.

[innerthunder]

git submodule update --remote --recursive --force usually does the trick for me

[PrabbyDD]

I tried running those commands and updating the submodule but it hasnt changed the conflict in github. Not really sure how to proceed, never seen something like this before.

[PrabbyDD]

Should I just make a new branch with these changes and try to redo it? I dont think I manually made changes to public/locales at any point in this branch

[DayKev]

Fixed it by merging beta locally, not sure what GitHub's problem was.

[DayKev]

Oh wait, that made it pull the latest remote commit...? What is even going on.

[DayKev]

Okay there we go, now it's fixed. Git can be very annoying sometimes...

[PrabbyDD]

Appreciated. Do you know how I can fix this locally?
When I run git submodule update --remote --recursive --force

I get
fatal: Needed a single revision
Unable to find current origin/master revision in submodule path 'public/locales'

I have tried

rm -rf public/locales
git submodule sync --recursive
git submodule update --init --recursive

and

git submodule update --remote --recursive --force

but it hasnt really changed anything...

[DayKev]

Hmmm... not sure. Submodules are weird. Try the following:

git reset --hard 07cea3f
git pull
git submodule update --progress --init --recursive --force

[PrabbyDD]

When I do that then I have to commit public/locales and once that is done then my local branch is ahead of upstream/beta by 16 commits which doesnt make sense to me - that means I have extra stuff in my repo right? I tried to delete the beta repo and re pull but same issue with public/locales exists...

[DayKev]

Oh wait you were trying to fix your local beta branch? In that case change the SHA1 in my above message to f2ef3620. So like this:

git reset --hard f2ef3620
git pull
git submodule update --progress --init --recursive --force

Sorry I thought you were trying to fix your local version of this PR branch. Hopefully that should fix your local version of the beta branch.

[PrabbyDD]

Got it, thanks!