[Move] Rage Fist Implementation

[geeilhan]

Continuation of this Rage Fist PR
(#3503)

What are the changes the user will see?

Confusion self inflicted hits does not count to the increased power of rage fist

What are the changes from a developer perspective?

Added a confHitCount to pokemon.battleData which only counts self inflicted hits due to confusion. this number gets subtracted from hitCount in order to get the correct hitCount value for rage fist

Screenshots/Videos

For reference look at the videos from this PR

How to test the changes?

Spam Splash until you get confused then use Rage Fist and pray for a self hit

const overrides = {
  OPP_SPECIES_OVERRIDE: Species.MAGIKARP,
  OPP_LEVEL_OVERRIDE: 1,
  OPP_MOVESET_OVERRIDE: [ Moves.CONFUSE_RAY, Moves.TACKLE ],
  MOVESET_OVERRIDE: [ Moves.RAGE_FIST, Moves.SPLASH ],
  STARTING_LEVEL_OVERRIDE: 100,
  STARTING_WAVE_OVERRIDE: 1,
} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

[SirzBenjie]

code looks good, but for cases like these I like to see automated tests. I can write, if necessary :)

As in, can we get an automated test specifically for ensuring confusion hits don't increase damage? I think you can mock the confusion check to force the mon to hit itself.

[geeilhan]

code looks good, but for cases like these I like to see automated tests. I can write, if necessary :)

As in, can we get an automated test specifically for ensuring confusion hits don't increase damage? I think you can mock the confusion check to force the mon to hit itself.

That would be nice. I couldn't write tests for the confusion case because I didn't know how to mock it.

[SirzBenjie]

code looks good, but for cases like these I like to see automated tests. I can write, if necessary :)
As in, can we get an automated test specifically for ensuring confusion hits don't increase damage? I think you can mock the confusion check to force the mon to hit itself.

That would be nice. I couldn't write tests for the confusion case because I didn't know how to mock it.

Okay, I'll add it 🫡