Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-1334] Fix sign-up and confirm sign-up pages #604

Merged
merged 26 commits into from
Feb 15, 2024
Merged

[DEV-1334] Fix sign-up and confirm sign-up pages #604

merged 26 commits into from
Feb 15, 2024

Conversation

marcobottaro
Copy link
Collaborator

@marcobottaro marcobottaro commented Feb 5, 2024 •
edited
Loading

Fix sign-up and confirm sign-up pages

List of Changes

It changes the UX of the sign-up page and the corresponding confirmation page according to Figma design
This PR depends on #601

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Sign-up page:
image

Confirm sign-up page:
image

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@marcobottaro marcobottaro self-assigned this Feb 5, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b0ecc80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This PR exceeds the recommended size of 800 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

kin0992
kin0992 reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@kin0992 kin0992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why didn't you split in two separate PRs the sign-in and the sign-up?

.changeset/lazy-poets-melt.md Outdated Show resolved Hide resolved
apps/nextjs-website/src/app/auth/login/page.tsx Outdated Show resolved Hide resolved
apps/nextjs-website/src/app/auth/login/page.tsx Outdated Show resolved Hide resolved
apps/nextjs-website/src/app/auth/login/page.tsx Outdated Show resolved Hide resolved
apps/nextjs-website/src/helpers/auth.helpers.ts Outdated Show resolved Hide resolved
@marcobottaro marcobottaro changed the base branch from main to DEV-1333-sign-in-and-confirm-sign-in February 6, 2024 10:49
@marcobottaro
Copy link
Collaborator Author

why didn't you split in two separate PRs the sign-in and the sign-up?

There are dependencies between the two branches. This PR depends on (and now points to) #601

This was referenced Feb 6, 2024
Merged
Merged
tommaso1
tommaso1 previously approved these changes Feb 8, 2024
View reviewed changes
MarcoPonchia
MarcoPonchia requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@MarcoPonchia MarcoPonchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast from 12-02-2024 15:25:04.webm
Subscribe button should became disable on click until BE respond

@marcobottaro marcobottaro mentioned this pull request Feb 13, 2024
Closed
7 tasks
datalek
datalek reviewed Feb 14, 2024
View reviewed changes
apps/nextjs-website/src/config.ts Outdated Show resolved Hide resolved
apps/nextjs-website/src/app/auth/sign-up/page.tsx Outdated Show resolved Hide resolved
apps/nextjs-website/src/app/auth/sign-up/page.tsx Outdated Show resolved Hide resolved
@marcobottaro marcobottaro requested a review from datalek February 14, 2024 17:33
@github-actions GitHub Actions
Copy link
Contributor

Branch is not up to date with base branch

@marcobottaro it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

@github-actions GitHub Actions
Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-1334

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@datalek datalek merged commit 7322534 into main Feb 15, 2024
9 of 10 checks passed
@datalek datalek deleted the DEV-1334-sign-up-and-confirm-sign-up branch February 15, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kin0992 kin0992 kin0992 left review comments

@MarcoPonchia MarcoPonchia MarcoPonchia approved these changes

@datalek datalek datalek approved these changes

@tommaso1 tommaso1 tommaso1 left review comments

Assignees

@marcobottaro marcobottaro

Labels
changeset size/small website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcobottaro @datalek @kin0992 @tommaso1 @MarcoPonchia @MikeAtUqido