-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IT Wallet): [SIW-1962] Remote presentation handle wallet instance presence #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
mastro993
reviewed
Feb 7, 2025
gispada
reviewed
Feb 7, 2025
ts/features/itwallet/presentation/remote/screens/ItwRemoteWalletInactiveScreen.tsx
Outdated
Show resolved
Hide resolved
mastro993
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
…ls in presentation (#6702) > [!WARNING] > Depends on #6694 ## Short description This PR adds a failure screen for missing credentials in the remote presentation flow. Note that since the presentation flow is still a work in progress, the screen is not fully implemented. ## List of changes proposed in this pull request - Improved typing of failure reasons - Added a case for missing credentials ## How to test Currently the only way to test the screen is to mock it, forcing the `MISSING_CREDENTIALS` failure. --------- Co-authored-by: RiccardoMolinari95 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
…ls in presentation (#6702) > [!WARNING] > Depends on #6694 ## Short description This PR adds a failure screen for missing credentials in the remote presentation flow. Note that since the presentation flow is still a work in progress, the screen is not fully implemented. ## List of changes proposed in this pull request - Improved typing of failure reasons - Added a case for missing credentials ## How to test Currently the only way to test the screen is to mock it, forcing the `MISSING_CREDENTIALS` failure. --------- Co-authored-by: RiccardoMolinari95 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR handles the presence of a wallet instance in the remote presentation flow
List of changes proposed in this pull request
ItwRemoteFailureScreen
to handle errorsactions
,guards
andevents
in remote presentation machinetest
for remote presentation machineHow to test
Test the remote presentation flow with the IT Wallet both active and inactive
IT Wallet inactive scenario
Screen.Recording.2025-02-06.at.15.29.00.mov
IT Wallet active scenario
Note
The screen displayed during this flow is a placeholder and is currently under development in other tasks.
Screen.Recording.2025-02-06.at.15.31.25.mov