Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IT Wallet): [SIW-1962] Remote presentation handle wallet instance presence #6694

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

RiccardoMolinari95
Copy link
Collaborator

@RiccardoMolinari95 RiccardoMolinari95 commented Feb 6, 2025

Short description

This PR handles the presence of a wallet instance in the remote presentation flow

List of changes proposed in this pull request

  • Handle the presence of a WI in remote presentation machine
  • Added ItwRemoteFailureScreen to handle errors
  • Added actions, guards and events in remote presentation machine
  • Added test for remote presentation machine

How to test

Test the remote presentation flow with the IT Wallet both active and inactive

IT Wallet inactive scenario

Screen.Recording.2025-02-06.at.15.29.00.mov

IT Wallet active scenario

Note

The screen displayed during this flow is a placeholder and is currently under development in other tasks.

Screen.Recording.2025-02-06.at.15.31.25.mov

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 13.63636% with 38 lines in your changes missing coverage. Please review.

Project coverage is 50.01%. Comparing base (eb50485) to head (b075986).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...entation/remote/screens/ItwRemoteFailureScreen.tsx 10.00% 18 Missing ⚠️
...es/itwallet/presentation/remote/machine/actions.ts 10.00% 9 Missing ⚠️
...res/itwallet/presentation/remote/machine/guards.ts 25.00% 3 Missing ⚠️
...remote/screens/ItwRemoteClaimsDisclosureScreen.tsx 0.00% 3 Missing ⚠️
...es/itwallet/presentation/remote/machine/machine.ts 33.33% 2 Missing ⚠️
.../itwallet/presentation/remote/machine/provider.tsx 0.00% 2 Missing ⚠️
.../itwallet/presentation/remote/machine/selectors.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6694      +/-   ##
==========================================
- Coverage   50.06%   50.01%   -0.06%     
==========================================
  Files        1556     1557       +1     
  Lines       32397    32438      +41     
  Branches     7289     7343      +54     
==========================================
+ Hits        16219    16223       +4     
- Misses      16139    16176      +37     
  Partials       39       39              
Files with missing lines Coverage Δ
ts/features/itwallet/common/utils/itwStoreUtils.ts 80.95% <ø> (ø)
...es/itwallet/presentation/remote/machine/failure.ts 20.00% <ø> (ø)
...tion/remote/navigation/ItwRemoteStackNavigator.tsx 44.44% <ø> (ø)
.../itwallet/presentation/remote/navigation/routes.ts 100.00% <ø> (ø)
.../itwallet/presentation/remote/machine/selectors.ts 50.00% <50.00%> (ø)
...es/itwallet/presentation/remote/machine/machine.ts 60.00% <33.33%> (-6.67%) ⬇️
.../itwallet/presentation/remote/machine/provider.tsx 33.33% <0.00%> (-16.67%) ⬇️
...res/itwallet/presentation/remote/machine/guards.ts 25.00% <25.00%> (-75.00%) ⬇️
...remote/screens/ItwRemoteClaimsDisclosureScreen.tsx 15.21% <0.00%> (-1.07%) ⬇️
...es/itwallet/presentation/remote/machine/actions.ts 10.00% <10.00%> (-90.00%) ⬇️
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb50485...b075986. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 added this pull request to the merge queue Feb 12, 2025
Merged via the queue into master with commit 20d6906 Feb 12, 2025
22 checks passed
@mastro993 mastro993 deleted the SIW-1962-remote-presentation-check-wi branch February 12, 2025 12:24
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2025
…ls in presentation (#6702)

> [!WARNING]
> Depends on #6694

## Short description
This PR adds a failure screen for missing credentials in the remote
presentation flow. Note that since the presentation flow is still a work
in progress, the screen is not fully implemented.

## List of changes proposed in this pull request
- Improved typing of failure reasons
- Added a case for missing credentials

## How to test
Currently the only way to test the screen is to mock it, forcing the
`MISSING_CREDENTIALS` failure.

---------

Co-authored-by: RiccardoMolinari95 <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2025
…ls in presentation (#6702)

> [!WARNING]
> Depends on #6694

## Short description
This PR adds a failure screen for missing credentials in the remote
presentation flow. Note that since the presentation flow is still a work
in progress, the screen is not fully implemented.

## List of changes proposed in this pull request
- Improved typing of failure reasons
- Added a case for missing credentials

## How to test
Currently the only way to test the screen is to mock it, forcing the
`MISSING_CREDENTIALS` failure.

---------

Co-authored-by: RiccardoMolinari95 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants