Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: random segmentation fault during detach using physics mutex #20

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

zabealbe
Copy link
Contributor

As already shown here if a detach is issued during a physics engine update a segmentation fault will be generated, resulting in Gazebo crashing.

I would like to share with you my own solution to the problem which I had the opportunity to extensively test and validate during the development of this project. The solution is simple, efficient and reliable and only consists in using the physics mutex accessible through physics->GetPhysicsUpdateMutex();

Copy link
Collaborator

@awesomebytes awesomebytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the simplicity of the fix!

Cold you please remove the readme changes so i can click on merging straight away?

Thank you very much!!

@zabealbe
Copy link
Contributor Author

Yep, Done

@awesomebytes awesomebytes merged commit 1d170c4 into pal-robotics:melodic-devel Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants