Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more precise type for formparser.MultiPartParser.parse return #2841

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Use more precise type for formparser.MultiPartParser.parse return #2841

merged 1 commit into from
Mar 3, 2024

Conversation

adamtheturtle
Copy link
Contributor

Without this change, pyright with typeCheckingMode set to strict reports:

error: Type of "fields" is partially unknown
    Type of "fields" is "MultiDict[Unknown, Unknown]" (reportUnknownVariableType)

when I use this method.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@adamtheturtle adamtheturtle mentioned this pull request Jan 24, 2024
Closed
@pgjones pgjones changed the base branch from main to 3.0.x February 29, 2024 20:30
@pgjones pgjones force-pushed the multipart-parser-strict-type branch from f422b8b to ccf4255 Compare February 29, 2024 20:33
@adamtheturtle @pgjones
Use more precise type for formparser.MultiPartParser.parse return
9154da6 
Without this change, `pyright` with `typeCheckingMode` set to `strict` reports:

```
error: Type of "fields" is partially unknown
    Type of "fields" is "MultiDict[Unknown, Unknown]" (reportUnknownVariableType)
```

when I use this method.
@pgjones pgjones force-pushed the multipart-parser-strict-type branch from ccf4255 to 9154da6 Compare February 29, 2024 20:38
@pgjones pgjones merged commit 70ad4d6 into pallets:3.0.x Mar 3, 2024
11 checks passed
@pgjones
Copy link
Member

pgjones commented Mar 3, 2024

Thank you

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
@adamtheturtle adamtheturtle deleted the multipart-parser-strict-type branch March 30, 2024 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pgjones pgjones pgjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyright in strict mode errors when using formparser.MultiPartParser.parse
2 participants
@adamtheturtle @pgjones