No longer allow implicit optional (mypy) #850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds necessary typing for mypy-compliance
To-Do List
Type of change
The breaking change is that the affected functions (with call signatures containing
*
) MUST now use keyword arguments to operate (entries can no longer be passed as positional arguments). I'm not sure how much of a breaking change this is forclimpred
, but if it is, I can mention that in the changelog.How Has This Been Tested?
Testing on GitHub Workflows
Checklist (while developing)
References
python/mypy#9091