Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer allow implicit optional (mypy) #850

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jan 3, 2024

Description

Adds necessary typing for mypy-compliance

To-Do List

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

The breaking change is that the affected functions (with call signatures containing *) MUST now use keyword arguments to operate (entries can no longer be passed as positional arguments). I'm not sure how much of a breaking change this is for climpred, but if it is, I can mention that in the changelog.

  • This change requires a documentation update

How Has This Been Tested?

Testing on GitHub Workflows

Checklist (while developing)

  • CHANGELOG is updated with reference to this PR.

References

python/mypy#9091

@Zeitsperre Zeitsperre self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ccf4a4) 91.67% compared to head (098b3dc) 91.67%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           pre-commit-ci-update-config     #850   +/-   ##
============================================================
  Coverage                        91.67%   91.67%           
============================================================
  Files                               59       59           
  Lines                             6246     6246           
============================================================
  Hits                              5726     5726           
  Misses                             520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aaronspring aaronspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Surprised to see 3.11 only fail but not the others

@Zeitsperre
Copy link
Collaborator Author

@aaronspring The reason is because that build tests the latest development versions of some deps. xclim is waiting on pandas v2.2 to release before we make a bunch of breaking changes (drop Python3.8, changes to frequency strings, support xarray>=2023.12, etc.) so our hands are tied until then.

@Zeitsperre Zeitsperre merged commit e11d976 into pre-commit-ci-update-config Jan 5, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants