Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed project not building #24

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Fixed project not building #24

merged 7 commits into from
Jul 23, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Jul 19, 2024 •
edited
Loading

  • Fix docker image not building
  • Fix CI not building

@Bullrich Bullrich self-assigned this Jul 19, 2024
@Bullrich Bullrich linked an issue Jul 19, 2024 that may be closed by this pull request
Project is not building #23
Closed
@Bullrich Bullrich force-pushed the build-fix branch 2 times, most recently from 83654c8 to 6bd9d06 Compare July 23, 2024 08:21
@Bullrich Bullrich marked this pull request as ready for review July 23, 2024 08:21
@Bullrich Bullrich requested a review from a team as a code owner July 23, 2024 08:21
mutantcornholio
mutantcornholio approved these changes Jul 23, 2024
View reviewed changes
Copy link

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bullrich Bullrich enabled auto-merge (squash) July 23, 2024 09:09
@Bullrich Bullrich merged commit f2cb0fe into main Jul 23, 2024
6 checks passed
@Bullrich Bullrich deleted the build-fix branch July 23, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutantcornholio mutantcornholio mutantcornholio approved these changes

@rzadp rzadp Awaiting requested review from rzadp

Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project is not building
2 participants
@Bullrich @mutantcornholio