Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed project not building #24

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Fixed project not building #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93d7bc3
added missing docker build steps
Bullrich Jul 19, 2024
cc61926
added step to evaluate docker image
Bullrich Jul 19, 2024
207b631
removed --ignore scripts
Bullrich Jul 19, 2024
7cf3282
skipped post install script
Bullrich Jul 23, 2024
3d17e7c
reverted @octokit/graphql-schema
Bullrich Jul 23, 2024
72feb41
added missing postinstall step
Bullrich Jul 23, 2024
aa79a65
removed prebuild from package.json
Bullrich Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/javascript-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ name: Continuous testing
on: [pull_request]

jobs:
test-image:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check that the image builds
run: docker build . --file Dockerfile

test:
strategy:
matrix:
Expand Down Expand Up @@ -33,6 +40,6 @@ jobs:
conclude:
runs-on: ubuntu-latest
name: All tests passed
needs: [test]
needs: [test, test-image]
steps:
- run: echo '### Good job! All the tests passed 🚀' >> $GITHUB_STEP_SUMMARY
7 changes: 5 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@ FROM node:22 as Builder

WORKDIR /action

COPY package.json yarn.lock ./
COPY .yarn/ ./.yarn/
COPY package.json yarn.lock .yarnrc.yml ./

RUN yarn install --immutable --ignore-scripts
RUN yarn install --immutable --mode skip-build

COPY . .

RUN yarn postinstall

RUN yarn run build

FROM node:22-slim
Expand Down
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
"fix": "npx eslint --fix 'src/**/*.ts' && npx prettier --write 'src/**/*.{ts,yml}'",
"lint": "npx eslint 'src/**/*.ts' && npx prettier --check 'src/**/*.{ts,yml}'",
"copy": "node scripts/copy-files.js",
"postinstall": "yarn run copy",
"prebuild": "yarn run copy"
"postinstall": "yarn run copy"
},
"repository": {
"type": "git",
Expand All @@ -36,7 +35,7 @@
},
"devDependencies": {
"@eng-automation/js-style": "^3.1.0",
"@octokit/graphql-schema": "^15.25.0",
"@octokit/graphql-schema": "^14.55.1",
"@octokit/webhooks-types": "^7.5.1",
"@types/jest": "^29.5.12",
"@types/showdown": "^2.0.6",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,13 +928,13 @@ __metadata:
languageName: node
linkType: hard

"@octokit/graphql-schema@npm:^15.25.0":
version: 15.25.0
resolution: "@octokit/graphql-schema@npm:15.25.0"
"@octokit/graphql-schema@npm:^14.55.1":
version: 14.58.0
resolution: "@octokit/graphql-schema@npm:14.58.0"
dependencies:
graphql: "npm:^16.0.0"
graphql-tag: "npm:^2.10.3"
checksum: 10c0/c61898d062aa2559a72a2ac3f573410053ca763fe2797f7c4b46ddfa0c435325a7645e8f4613a6d39368d5b66db98b126efdb20ccb370b263eaaab5a67d1e2aa
checksum: 10c0/e423c0394704ade3d5b425ac51a82cedf6316bfa38cb5e60228281f7a3fae2ab246b53b8bbdb4fb8c26281eca7ae441d1402676410cab90bb234bd09e2a0cd28
languageName: node
linkType: hard

Expand Down Expand Up @@ -4384,7 +4384,7 @@ __metadata:
"@actions/core": "npm:^1.10.1"
"@actions/github": "npm:^6.0.0"
"@eng-automation/js-style": "npm:^3.1.0"
"@octokit/graphql-schema": "npm:^15.25.0"
"@octokit/graphql-schema": "npm:^14.55.1"
"@octokit/webhooks-types": "npm:^7.5.1"
"@types/jest": "npm:^29.5.12"
"@types/showdown": "npm:^2.0.6"
Expand Down