Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add omni bencher & chain-spec-builder bins to release #4557

Merged
merged 19 commits into from
May 29, 2024
Merged

Add omni bencher & chain-spec-builder bins to release #4557

merged 19 commits into from
May 29, 2024

Conversation

EgorPopelyaev
Copy link
Contributor

@EgorPopelyaev EgorPopelyaev commented May 23, 2024 •
edited
Loading

Closes: #4354

This PR adds the steps to build and attach frame-omni-bencher and chain-spec-builder binaries to the release draft

TODO

@EgorPopelyaev EgorPopelyaev added the R0-silent Changes should not be mentioned in any release notes label May 23, 2024
@bkontur
Copy link
Contributor

bkontur commented May 24, 2024

@kianenigma
Do we need here this rlib?

[lib]
crate-type = ["rlib"]

@EgorPopelyaev EgorPopelyaev changed the title Add omni bencher bin to release Add omni bencher & chain-spec-builder bins to release May 24, 2024
EgorPopelyaev and others added 2 commits May 24, 2024 12:10
@EgorPopelyaev @bkontur
use production profile
771a366 
Co-authored-by: Branislav Kontur <[email protected]>
@EgorPopelyaev @bkontur
use production profile
e449ac0 
Co-authored-by: Branislav Kontur <[email protected]>
@bkontur bkontur mentioned this pull request May 24, 2024
Merged
1 task
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6285730

@EgorPopelyaev EgorPopelyaev marked this pull request as ready for review May 27, 2024 08:47
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners May 27, 2024 08:47
@EgorPopelyaev
Copy link
Contributor Author

@kianenigma @bkontur guys, the flow is working now and both bins can be built and attached to the release.
Regarding the check that the version of the chain-spec-builder should match the sp-genesis-builder, not sure what to do with that, should be done here as part of the pipeline?

@kianenigma
Copy link
Contributor

@kianenigma Do we need here this rlib?

[lib]
crate-type = ["rlib"]

I don't think so, but I am also not the original author of the crate to know why it was there to begin with. From what I read about the definition of rlib, it can be removed. Is it causing issues with the release?

@bkontur
Copy link
Contributor

bkontur commented May 28, 2024

@kianenigma Do we need here this rlib?

[lib]
crate-type = ["rlib"]

I don't think so, but I am also not the original author of the crate to know why it was there to begin with. From what I read about the definition of rlib, it can be removed. Is it causing issues with the release?

@kianenigma no, there is no problem, it just caught my attention, and we don' use it elsewhere except two binaries: polkadot-cli and staging-node-cli

and to the same versioning for those two crates, please continue discussions here: #4518 (comment)

@EgorPopelyaev EgorPopelyaev requested a review from pavelsupr May 28, 2024 10:14
pavelsupr
pavelsupr approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@pavelsupr pavelsupr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is OK in this specific commit for me, but the initial release file contained a binary dependency (L. 76) from a single developer without pinning/checks of the integrity of it. IMO it should be localised or replaced.

@EgorPopelyaev EgorPopelyaev added this pull request to the merge queue May 29, 2024
Merged via the queue into paritytech:master with commit 89604da May 29, 2024
153 of 156 checks passed
@EgorPopelyaev EgorPopelyaev deleted the epo-add-omni-bencher-bin-to-release branch May 29, 2024 06:12
EgorPopelyaev added a commit that referenced this pull request May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
320cea6 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev added a commit that referenced this pull request May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
77cf446 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
@bkontur bkontur mentioned this pull request May 29, 2024
Closed
8 tasks
github-merge-queue bot pushed a commit that referenced this pull request May 29, 2024
@kianenigma @bkontur
Publish chain-spec-builder (#4518)
dfcfa4a 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request May 30, 2024
@kianenigma @bkontur @EgorPopelyaev
Publish chain-spec-builder (#4518)
9970c63 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request May 30, 2024
@kianenigma @bkontur @EgorPopelyaev
Publish chain-spec-builder (#4518)
afd8337 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
ordian added a commit that referenced this pull request May 30, 2024
@ordian
Merge branch 'master' into ao-statement-distribution-reenabling-prep
9684df4 
* master: (93 commits)
  Fix broken windows build (#4636)
  Beefy client generic on aduthority Id (#1816)
  pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620)
  Broker new price adapter (#4521)
  Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621)
  Update README.md (#4623)
  Publish `chain-spec-builder` (#4518)
  Add omni bencher & chain-spec-builder bins to release (#4557)
  Moves runtime macro out of experimental flag (#4249)
  Filter workspace dependencies in the templates (#4599)
  parachain-inherent: Make `para_id` more prominent (#4555)
  Add metric to measure the time it takes to gather enough assignments (#4587)
  Improve On_demand_assigner events (#4339)
  Conditional `required` checks (#4544)
  [CI] Deny adding git deps (#4572)
  [subsytem-bench] Remove redundant banchmark_name param (#4540)
  Add availability-recovery from systematic chunks (#1644)
  Remove workspace lints from templates (#4598)
  `sc-chain-spec`: deprecated code removed (#4410)
  [subsystem-benchmarks] Add statement-distribution benchmarks (#3863)
  ...
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@EgorPopelyaev @bkontur @hitchhooker
Add omni bencher & chain-spec-builder bins to release (paritytech#4557)
b89eb60 
Closes: paritytech#4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](paritytech#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@kianenigma @bkontur @hitchhooker
Publish chain-spec-builder (paritytech#4518)
f8dd3dc 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes paritytech#4352

- [x] Add to release artifacts ~~similar to
paritytech#4405 done here:
paritytech#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@EgorPopelyaev @bkontur @TarekkMA
Add omni bencher & chain-spec-builder bins to release (paritytech#4557)
c0d6451 
Closes: paritytech#4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](paritytech#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@kianenigma @bkontur @TarekkMA
Publish chain-spec-builder (paritytech#4518)
3fedbd6 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes paritytech#4352

- [x] Add to release artifacts ~~similar to
paritytech#4405 done here:
paritytech#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelsupr pavelsupr pavelsupr approved these changes

@alvicsam alvicsam alvicsam approved these changes

@bkontur bkontur bkontur approved these changes

@AndWeHaveAPlan AndWeHaveAPlan AndWeHaveAPlan approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release frame-omni-bencher
7 participants
@EgorPopelyaev @bkontur @paritytech-cicd-pr @kianenigma @AndWeHaveAPlan @alvicsam @pavelsupr