kustomize deployment of all workflows #81
Conversation
kustomize/move2kube/move2kube.md
Outdated
There was a problem hiding this comment.
this will contains what? The content of INTALL.md?
There was a problem hiding this comment.
for escalation I put a simple arch description with mermaid diagrams, see here. But we can remove it completely
There was a problem hiding this comment.
The CRD for the MTA operator (for Tackle resource) is missing and needs to be applied prior to applying the Tackle manifest
Also, as we will have a growing amount of workflows, it would be nice to have a Makfile like they did to built kogito-apps image (ie: https://github.com/apache/incubator-kie-kogito-images?tab=readme-ov-file#building-images) ==> may be another PR
kustomize/move2kube/README.md
Outdated
|
|
||
| You can monitor the deployment status with: | ||
| ```bash | ||
| oc get sonataflow m2k -n sonataflow-infra -owide |
There was a problem hiding this comment.
should be
oc get sonataflow m2k -n ${TARGET_NS} -owide
kustomize/move2kube/README.md
Outdated
|
|
||
| And finally view the logs with: | ||
| ```bash | ||
| oc logs -f -n sonataflow-infra -l app=m2k |
There was a problem hiding this comment.
same as above, the namespace should be parameterized too (${TARGET_NS} instead of sonataflow-infra)
Did you also apply the prerequisites?
|
dmartinol
changed the title
No I missed that part |
|
| And finally view the logs with: | ||
| ```bash | ||
| oc logs -f -n ${TARGET_NS} -l app=m2k | ||
| ``` |
There was a problem hiding this comment.
IMO, even if you reference the INSTALL.md file, you should copy/paste the steps when you update the move2kube URLs: provide the command to do it or at least the location of the file and the props to edit and then put the kustomize apply command again to apply those and then the command to restart the m2k pods to reflect the changes of the CM to the pods
There was a problem hiding this comment.
I'm not following you here: are you referring to the pre-installation steps or the fact that whenever you update the CM/Secret mounted to the Pod's envFrom the Pod is not restarted? (which is a different issue, and BTW tracked by apache/incubator-kie-kogito-serverless-operator#298)
Pls clarify
There was a problem hiding this comment.
Updated the README to clarify that the MOVE2KUBE_URL and MOVE2KUBE_API properties must match the exposed Route, but I would not make it a 2 steps installation. On the contrary, I would be tempted to split the configuration in 2 to isolate the installation of Move2Kube that, BTW, may also be already installed in the cluster or anywhere else. But not today, of course 😉
There was a problem hiding this comment.
I would be tempted to split the configuration in 2 to isolate the installation of Move2Kube
That would be fine for me too, like in move2kube.md too add/move some steps
But that is for later for sure
|
We are good to go Houston! 🚀 |
See description of changes in the newly added README.md (last section) for move2kube
PS: The manifests were copied from the latest generation in a local repo (main branch). There are little changes compared to the version in the Helm charts, I did not update it for now