Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize deployment of all workflows #81
kustomize deployment of all workflows #81
Changes from 1 commit
2d87276
402be2c
1772fd2
57d7f8b
5184a41
6cceeb5
016deaa
4633732
bc65da8
2d050fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, the namespace should be parameterized too (
${TARGET_NS}
instead ofsonataflow-infra
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, even if you reference the INSTALL.md file, you should copy/paste the steps when you update the move2kube URLs: provide the command to do it or at least the location of the file and the props to edit and then put the kustomize apply command again to apply those and then the command to restart the m2k pods to reflect the changes of the CM to the pods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following you here: are you referring to the pre-installation steps or the fact that whenever you update the CM/Secret mounted to the Pod's
envFrom
the Pod is not restarted? (which is a different issue, and BTW tracked by apache/incubator-kie-kogito-serverless-operator#298)Pls clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the README to clarify that the
MOVE2KUBE_URL
andMOVE2KUBE_API
properties must match the exposed Route, but I would not make it a 2 steps installation. On the contrary, I would be tempted to split the configuration in 2 to isolate the installation ofMove2Kube
that, BTW, may also be already installed in the cluster or anywhere else. But not today, of course 😉There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be fine for me too, like in
move2kube.md
too add/move some stepsBut that is for later for sure