-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert all number data types to float #1027
Merged
nitisht
merged 6 commits into
parseablehq:main
from
nikhilsinhaparseable:data-type-float
Dec 11, 2024
Merged
fix: convert all number data types to float #1027
nitisht
merged 6 commits into
parseablehq:main
from
nikhilsinhaparseable:data-type-float
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
reviewed
Dec 9, 2024
de-sh
reviewed
Dec 9, 2024
de-sh
reviewed
Dec 9, 2024
nikhilsinhaparseable
force-pushed
the
data-type-float
branch
from
December 10, 2024 16:00
676a84c
to
8550152
Compare
server checks if event has any number (all ints and floats) then update the data type of all numbers to Float64
nikhilsinhaparseable
force-pushed
the
data-type-float
branch
from
December 10, 2024 16:52
ffc1411
to
5e4f89f
Compare
Pull Request Test Coverage Report for Build 12276648166Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
de-sh
reviewed
Dec 11, 2024
de-sh
approved these changes
Dec 11, 2024
Co-authored-by: Devdutt Shenoi <[email protected]> Signed-off-by: Nitish Tiwari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server checks if event has any number (all ints and floats)
then update the data type of all numbers to Float64