Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure amount #560

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Restructure amount #560

merged 4 commits into from
Jun 14, 2024

Conversation

rays22
Copy link
Collaborator

@rays22 rays22 commented Jun 13, 2024

  • Created a quantitative branch.
  • Moved amount under this.
  • Made concentration a child of amount.
  • Removed reciprocal relation to ‘has number of’.
  • Make has number of a child of amount.

If applied, this commit will fix #554.

* Created a quantitative branch.
* Moved amount under this.
* Made concentration a child of amount.
* Removed reciprocal relation to ‘has number of’.
* Make has number of a child of amount.

If applied, this commit will fix #554.
@rays22 rays22 self-assigned this Jun 13, 2024
@rays22 rays22 requested a review from sbello June 13, 2024 17:34
If applied, this commit will fix #554.
Copy link
Contributor

@sbello sbello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the definition of quantitative, it might be better to avoid using 'amount' since that is a child term.
NLM has the definition of quantitative data "Quantitative data are data represented numerically, including anything that can be counted, measured, or given a numerical value." https://www.nnlm.gov/guides/data-glossary/quantitative-data
Possibly we could adapt this to "a quality of an entity that can be represented numerically, including anything that can be counted, measured, or given a numerical value"
This could then be used as a model to define the qualitative branch ""a quality of an entity that is descriptive or observational, typically not represented numerically" https://libguides.macalester.edu/c.php?g=527786&p=3608639 https://www.ncbi.nlm.nih.gov/books/NBK470395/
Defining qualitative wasn't part of this ticket but would be good to do.
Otherwise I think this looks good

@rays22
Copy link
Collaborator Author

rays22 commented Jun 13, 2024

Quantitative data are data represented numerically, including anything that can be counted, measured, or given a numerical value." https://www.nnlm.gov/guides/data-glossary/quantitative-data
Possibly we could adapt this to "a quality of an entity that can be represented numerically, including anything that can be counted, measured, or given a numerical value"
This could then be used as a model to define the qualitative branch ""a quality of an entity that is descriptive or observational, typically not represented numerically" https://libguides.macalester.edu/c.php?g=527786&p=3608639 https://www.ncbi.nlm.nih.gov/books/NBK470395/
Defining qualitative wasn't part of this ticket but would be good to do.

Thanks @sbello ,
1.I have updated the text or the definition of 'quantitative', and
2. added the definition to 'qualitative' that you suggest.

@sbello
Copy link
Contributor

sbello commented Jun 13, 2024

@rays22 please add the xrefs to the definitions for quantitative and qualitative so we can track where these came from (links in previous comment)

Copy link
Contributor

@sbello sbello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Ray

@rays22 rays22 merged commit f46a68f into master Jun 14, 2024
1 check passed
@rays22 rays22 deleted the issue554 branch June 14, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restructure amount
2 participants