-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure amount #560
Restructure amount #560
Conversation
* Created a quantitative branch. * Moved amount under this. * Made concentration a child of amount. * Removed reciprocal relation to ‘has number of’. * Make has number of a child of amount. If applied, this commit will fix #554.
If applied, this commit will fix #554.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the definition of quantitative, it might be better to avoid using 'amount' since that is a child term.
NLM has the definition of quantitative data "Quantitative data are data represented numerically, including anything that can be counted, measured, or given a numerical value." https://www.nnlm.gov/guides/data-glossary/quantitative-data
Possibly we could adapt this to "a quality of an entity that can be represented numerically, including anything that can be counted, measured, or given a numerical value"
This could then be used as a model to define the qualitative branch ""a quality of an entity that is descriptive or observational, typically not represented numerically" https://libguides.macalester.edu/c.php?g=527786&p=3608639 https://www.ncbi.nlm.nih.gov/books/NBK470395/
Defining qualitative wasn't part of this ticket but would be good to do.
Otherwise I think this looks good
Thanks @sbello , |
@rays22 please add the xrefs to the definitions for quantitative and qualitative so we can track where these came from (links in previous comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks Ray
If applied, this commit will fix #554.