-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated depencencies regarding prettier #1307
Merged
JosefBredereck
merged 12 commits into
pattern-lab:dev
from
mfranzke:refactor-updated-depencencies-prettier
Apr 17, 2021
Merged
refactor: updated depencencies regarding prettier #1307
JosefBredereck
merged 12 commits into
pattern-lab:dev
from
mfranzke:refactor-updated-depencencies-prettier
Apr 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and updated to the new config storage model and removed husky and pretty-quick from packages/core, as this should be possible to get triggered from root
and removed rules "trailingComma": "es5" as this is the new default
as well as moved husky to the devDependencies, as defined by the software doc itself
This was referenced Mar 28, 2021
Merged
that was enforced like this by eslint
Yarn 2 doesn't support prepare lifecycle script, so husky needs to be installed differently (this doesn't apply to Yarn 1 though)
This reverts commit e834b42.
JosefBredereck
approved these changes
Apr 17, 2021
This was referenced Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
prettier
"trailingComma": "es5"
from the configuration as this got the new default fortrailingComma
with version 2 ofprettier
pretty-quick
husky
husky
s way of configuring theprecommit
scripts (byprepare
)husky
withinroot
of the monorepo and removed fromcore
as suggested within several support articles and within huskys documentation: https://typicode.github.io/husky/#/?id=monoreposource: https://typicode.github.io/husky/#/?id=install
prettier/prettier
)#updatingdependenciesbitbybitbybitbybitbybitbybitbybitbybit