add DPoP keygen and thumbprint #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 71.84% 72.40% +0.56%
==========================================
Files 23 23
Lines 1900 1939 +39
Branches 233 236 +3
==========================================
+ Hits 1365 1404 +39
Misses 525 525
Partials 10 10 ☔ View full report in Codecov by Sentry. |
alphabetize import and clarify base64 test case add keypair generation and thumbprint confirmation
jshawl
commented
Feb 16, 2024
| type KeyPair = {| | ||
| privateKey: mixed, | ||
| publicKey: mixed, | ||
| |}; |
There was a problem hiding this comment.
not yet supported in flow - https://github.com/facebook/flow/blame/aa9112fd181e484ef63db0f7c2593d0c547046e6/lib/bom.js#L40-L47
jshawl
commented
Feb 16, 2024
| usages | ||
| ); | ||
|
|
||
| keyPair = keyPair || { publicKey, privateKey }; |
There was a problem hiding this comment.
^ this is for https://eslint.org/docs/latest/rules/require-atomic-updates
we know no other function mutates keyPair but eslint wanted me to read the value one last time before reassignment.
jshawl
requested review from
wsbrunson,
ravishekhar,
nbierdeman,
nikrom17 and
spencersablan
nikrom17
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #184 and implements key pair generation and a
jsonWebKeyThumbprintfunction that serializes and hashes a JSON web key.The next (last) PR will implement the JWT creation and signature.