Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query param validation #55

Merged
merged 2 commits into from
Mar 4, 2024
Merged

query param validation #55

merged 2 commits into from
Mar 4, 2024

Conversation

emilien-puget
Copy link
Contributor

@emilien-puget emilien-puget commented Feb 25, 2024 •
edited
Loading

add the support to validate query simple params like

parameters:
  - name: fishy
    in: query
    required: true
    schema:
      type: string
      minLength: 4
parameters:
  - name: fishy
    in: query
    required: true
    schema:
      type: number
      minimum: 200

@emilien-puget emilien-puget mentioned this pull request Feb 25, 2024
Closed
@emilien-puget emilien-puget mentioned this pull request Feb 26, 2024
Closed
daveshanley
daveshanley approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emilien-puget
Copy link
Contributor Author

@daveshanley i figured we could benefit for more tests

@emilien-puget emilien-puget mentioned this pull request Mar 2, 2024
Merged
@emilien-puget
Copy link
Contributor Author

Can we merge this @daveshanley ?

@daveshanley daveshanley merged commit 13c8231 into pb33f:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveshanley daveshanley daveshanley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilien-puget @daveshanley