-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibc: use outbound_ics20_transfers_enabled chain parameter #4101
Conversation
@@ -116,7 +116,19 @@ impl AppActionHandler for Action { | |||
.execute(state) | |||
.await | |||
} | |||
Action::Ics20Withdrawal(action) => action.check_and_execute(state).await, | |||
Action::Ics20Withdrawal(action) => { | |||
// SAFETY: this is safe to check in parallel because IBC enablement cannot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to use check_historical
then right? here it will get run sequentially before execution
This is consensus-breaking (modification to validation rules), but it's not state-breaking because it doesn't require a migration to deploy (and doesn't modify the state schema) |
Discussed with @avahowell & @erwanor : we're going to merge this today, so it's included in v0.70.0 (#4087). |
this uses the existing outbound_ics20_transfers_enabled to gate ics20 withdrawals