Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibc: use outbound_ics20_transfers_enabled chain parameter #4101

Merged
merged 3 commits into from
Mar 26, 2024
Merged

ibc: use outbound_ics20_transfers_enabled chain parameter #4101

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fa7cc2
ibc: use outbound_ics20_transfers_enabled chain parameter
avahowell Mar 26, 2024
c2c28ed
move outbound_ics20_transfers_enable to check_historical
avahowell Mar 26, 2024
8c64a2b
fix error text
avahowell Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion crates/core/app/src/action_handler/actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,19 @@ impl AppActionHandler for Action {
.execute(state)
.await
}
Action::Ics20Withdrawal(action) => action.check_and_execute(state).await,
Action::Ics20Withdrawal(action) => {
// SAFETY: this is safe to check in parallel because IBC enablement cannot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to use check_historical then right? here it will get run sequentially before execution

// change during transaction execution.
if !state
.get_ibc_params()
.await?
.outbound_ics20_transfers_enabled
{
anyhow::bail!("transaction contains IBC actions, but IBC is not enabled");
}

action.check_and_execute(state).await
}
Action::CommunityPoolSpend(action) => action.check_and_execute(state).await,
Action::CommunityPoolOutput(action) => action.check_and_execute(state).await,
Action::CommunityPoolDeposit(action) => action.check_and_execute(state).await,
Expand Down
Loading