Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase #1574 getter refactor #1768

Merged
merged 2 commits into from
Sep 4, 2024
Merged

rebase #1574 getter refactor #1768

merged 2 commits into from
Sep 4, 2024

Conversation

turbocrime
Copy link
Contributor

@turbocrime turbocrime commented Sep 4, 2024

main failed CI on merge of #1574

some commits merged using the old style getters, but it didn't trigger a merge conflict so the PR didn't prompt for a rebase.

now corrected.

https://github.com/penumbra-zone/web/compare/a7ed0ab..c2e7933

@turbocrime turbocrime requested review from grod220, VanishMax and a team September 4, 2024 16:24
Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 38a21b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@penumbra-zone/getters Major
minifront Patch
@penumbra-zone/perspective Major
@penumbra-zone/query Major
@penumbra-zone/services Major
@penumbra-zone/storage Major
@penumbra-zone/types Major
@penumbra-zone/ui Patch
node-status Patch
@penumbra-zone/crypto-web Major
@penumbra-zone/wasm Major
@repo/tailwind-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Visit the preview URL for this PR (updated for commit 38a21b4):

https://penumbra-ui-preview--pr1768-turbocrime-getter-re-i1ek3ohw.web.app

(expires Wed, 11 Sep 2024 19:07:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@turbocrime turbocrime merged commit 3a5c074 into main Sep 4, 2024
8 checks passed
@turbocrime turbocrime deleted the turbocrime/getter-refactor branch September 4, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants