Add theme & lib/toast UI exports #1887
Conversation
🦋 Changeset detectedLatest commit: 3f4a551 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "types": "./dist/src/PenumbraUIProvider/theme.d.ts", | ||
| "default": "./dist/src/PenumbraUIProvider/theme.js" | ||
| }, | ||
| "./lib/toast/*": { |
There was a problem hiding this comment.
issue: this is the old toast library, it should not be exported. The v2 one is already working in the dex: https://github.com/penumbra-zone/dex-explorer/pull/118/files#diff-e1b5cf1eb29b361c28415989517c8312f1f349ab3e0cac44425ffc02290259c2R62
| @@ -46,6 +48,18 @@ | |||
| "types": "./dist/components/ui/*.d.ts", | |||
| "default": "./dist/components/ui/*.js" | |||
| }, | |||
| "./theme": { | |||
There was a problem hiding this comment.
question: why is the theme needed to be exported, especially this way? We use PenumbraUIProvider in the app/app.tsx in the DEX.
suggestion: let's just export the theme object from PenumbraUIProvider/index.tsx file
| @@ -33,6 +33,8 @@ | |||
| "./tailwind": "./src/tailwindConfig.ts", | |||
| "./postcss.config.js": "./postcss.config.js", | |||
| "./styles/*": "./styles/*", | |||
| "./theme": "./src/PenumbraUIProvider/theme.ts", | |||
| "./utils/*": "./src/utils/*.ts", | |||
There was a problem hiding this comment.
question: is there something in the v1 utils we need in the DEX?
Currently we can't access theme and lib/toast within the dex-explorer. This should fix that.