-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme & lib/toast UI exports #1887
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@penumbra-zone/ui': minor | ||
--- | ||
|
||
Add theme and lib/toast exports |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,8 @@ | |
"./tailwind": "./src/tailwindConfig.ts", | ||
"./postcss.config.js": "./postcss.config.js", | ||
"./styles/*": "./styles/*", | ||
"./theme": "./src/PenumbraUIProvider/theme.ts", | ||
"./utils/*": "./src/utils/*.ts", | ||
"./hooks/*": "./src/hooks/*/index.ts", | ||
"./*": "./src/*/index.tsx" | ||
}, | ||
|
@@ -46,6 +48,18 @@ | |
"types": "./dist/components/ui/*.d.ts", | ||
"default": "./dist/components/ui/*.js" | ||
}, | ||
"./theme": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: why is the theme needed to be exported, especially this way? We use suggestion: let's just export the |
||
"types": "./dist/src/PenumbraUIProvider/theme.d.ts", | ||
"default": "./dist/src/PenumbraUIProvider/theme.js" | ||
}, | ||
"./lib/toast/*": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue: this is the old toast library, it should not be exported. The v2 one is already working in the dex: https://github.com/penumbra-zone/dex-explorer/pull/118/files#diff-e1b5cf1eb29b361c28415989517c8312f1f349ab3e0cac44425ffc02290259c2R62 |
||
"types": "./dist/lib/toast/*.d.ts", | ||
"default": "./dist/lib/toast/*.js" | ||
}, | ||
"./utils/*": { | ||
"types": "./dist/src/utils/*.d.ts", | ||
"default": "./dist/src/utils/*.js" | ||
}, | ||
"./*": { | ||
"types": "./dist/src/*/index.d.ts", | ||
"default": "./dist/src/*/index.js" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is there something in the v1 utils we need in the DEX?