Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retaring the FT sensor from the teleop subcomponent #142

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Aug 22, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

Sometimes, if the user is teleoperating the robot over a large trajectory, the F/T sensor will trip because it has moved too much since re-taring. As of now, there is no way to perform that re-taring in the web app. This PR addresses that by adding a button to the TeleopSubcomponent, always accessible through the Info modal, that allows users to re-tare the force-torque sensor.

Explain how this pull request was tested, including but not limited to the below checkmarks.

  • Launch the system in --sim mock.
  • Go into the Info modal. Verify the re-tare button exists.
  • Click the re-tare button. Go to screen -r ft. Verify the request to re-tare was received.

Future Work

Consider whether to add this to the customization pages as well.


Before creating a pull request

  • Format React code with npm run format
  • [N/A] Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati
Copy link
Contributor Author

Also tested in real.

@amalnanavati amalnanavati merged commit e7ca7eb into main Aug 25, 2024
4 checks passed
@amalnanavati amalnanavati deleted the amaln/retare_ft_sensor branch August 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant