Skip to content

Exclude DisallowShortOpenTag from .yml files #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2025
Merged

Exclude DisallowShortOpenTag from .yml files #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca7edf9
Exclude DisallowShortOpenTag from .yml files
jonathan1055 Jul 13, 2025
884d5cf
Merge branch 'pfrenssen:8.3.x' into 3535411-exclude-sniffs-from-yml
jonathan1055 Oct 13, 2025
9d70ab5
Add good.yml to demonstrate the problem
jonathan1055 Oct 13, 2025
80df663
Uncomment the new exclude
jonathan1055 Oct 13, 2025
59c56f3
Remove unnecessary change to ruleset.xml. Demonstrate test failure
jonathan1055 Oct 14, 2025
0e58c15
Add back the exclude, to fix the test
jonathan1055 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion coder_sniffer/Drupal/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@
<rule ref="Generic.NamingConventions.ConstructorName"/>
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
<rule ref="Generic.PHP.DeprecatedFunctions"/>
<rule ref="Generic.PHP.DisallowShortOpenTag"/>
<rule ref="Generic.PHP.DisallowShortOpenTag">
<!-- Do not run this sniff on .yml files -->
<exclude-pattern>*.yml</exclude-pattern>
</rule>
<rule ref="Generic.PHP.LowerCaseKeyword"/>
<rule ref="Generic.PHP.UpperCaseConstant"/>
<rule ref="Generic.Strings.UnnecessaryStringConcat">
Expand Down
3 changes: 3 additions & 0 deletions tests/Drupal/good/good.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
top_level:
# Generic.PHP.DisallowShortOpenTag should not complain at the short xml tag below.
data: '<?xml anything ?>\n'