Exclude DisallowShortOpenTag from .yml files #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausi
reviewed
Oct 12, 2025
coder_sniffer/Drupal/ruleset.xml
Outdated
| <rule ref="Generic.PHP.DisallowShortOpenTag"/> | ||
| <rule ref="Generic.PHP.DisallowShortOpenTag"> | ||
| <!-- Do not run this sniff on .yml files --> | ||
| <exclude-pattern>**/*.yml</exclude-pattern> |
There was a problem hiding this comment.
any reason why we need **? Other exclusions in this file just use <exclude-pattern>*.tpl.php</exclude-pattern>
There was a problem hiding this comment.
Um, no. It's 3 months ago and I can't recall why I did it like that! Maybe I did not look at the rest of the file and just used a pattern that I thought was necessary. Other filepath patterns need a double ** (eg ESLint ignore, I think). I didn't do too much testing at the time, as I had no idea if you would take on this suggestion. Now that I know it's on, I will add test coverage
There was a problem hiding this comment.
I have removed the double ** and added a good/good.yml file to demonstrate the failure, then the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not run Generic.PHP.DisallowShortOpenTag on .yml files
Drupal issue https://www.drupal.org/project/coder/issues/3535411