Skip to content

Exclude DisallowShortOpenTag from .yml files #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2025
Merged

Exclude DisallowShortOpenTag from .yml files #268

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca7edf9
Exclude DisallowShortOpenTag from .yml files
jonathan1055 Jul 13, 2025
884d5cf
Merge branch 'pfrenssen:8.3.x' into 3535411-exclude-sniffs-from-yml
jonathan1055 Oct 13, 2025
9d70ab5
Add good.yml to demonstrate the problem
jonathan1055 Oct 13, 2025
80df663
Uncomment the new exclude
jonathan1055 Oct 13, 2025
59c56f3
Remove unnecessary change to ruleset.xml. Demonstrate test failure
jonathan1055 Oct 14, 2025
0e58c15
Add back the exclude, to fix the test
jonathan1055 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion coder_sniffer/Drupal/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@
<rule ref="Generic.NamingConventions.ConstructorName"/>
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
<rule ref="Generic.PHP.DeprecatedFunctions"/>
<rule ref="Generic.PHP.DisallowShortOpenTag"/>
<rule ref="Generic.PHP.DisallowShortOpenTag">
<!-- Do not run this sniff on .yml files -->
<exclude-pattern>**/*.yml</exclude-pattern>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we need **? Other exclusions in this file just use <exclude-pattern>*.tpl.php</exclude-pattern>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, no. It's 3 months ago and I can't recall why I did it like that! Maybe I did not look at the rest of the file and just used a pattern that I thought was necessary. Other filepath patterns need a double ** (eg ESLint ignore, I think). I didn't do too much testing at the time, as I had no idea if you would take on this suggestion. Now that I know it's on, I will add test coverage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the double ** and added a good/good.yml file to demonstrate the failure, then the fix.

</rule>
<rule ref="Generic.PHP.LowerCaseKeyword"/>
<rule ref="Generic.PHP.UpperCaseConstant"/>
<rule ref="Generic.Strings.UnnecessaryStringConcat">
Expand Down