Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM specifiacation #80

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

@t-kataym
Copy link
Contributor

t-kataym commented Jul 28, 2023

@mkgrgis , Thank you for creating the PR.
Is it no problem to start the review?

@MinhLA1410 ,
Please review it if it is ready.

@mkgrgis
Copy link
Contributor Author

mkgrgis commented Jul 29, 2023

@mkgrgis , Thank you for creating the PR. Is it no problem to start the review?

Yes, no problems. I'll study about RPM directive words if there will detected any problems.

@MinhLA1410
Copy link
Contributor

Hi @mkgrgis
I tried to build rpm file from your spec. But it does not work. Could you please check again

error: parse error in expression
error: ${HOME}/sqlite_fdw/rpm.spec:25: bad %if condition

@mkgrgis
Copy link
Contributor Author

mkgrgis commented Aug 11, 2023

Thanks, @MinhLA1410 ! I'll try to get rpm environment, reproduce this problem and check again.

@devrimgunduz
Copy link

devrimgunduz commented Aug 11, 2023

Why are you trying to add spec file to sqlite_fdw repo? I'm already maintaining it in upstream repo. Also this spec file depends lots of things in the PostgreSQL RPM repo, it is not a standalone one.

@mkgrgis
Copy link
Contributor Author

mkgrgis commented Aug 11, 2023

Hello, @devrimgunduz ! Thanks for reply and for rpms :-) . I try to add spec file because i want to get rpm files for my colleagues with some new features or with my experiments for user testing. Your rpm files with sqlite_fdw likes me because there is good implementation of lifecycle processes.

@mkgrgis mkgrgis mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants