Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud parser refactor #74

Merged
merged 20 commits into from
Jun 26, 2020
Merged

Cloud parser refactor #74

merged 20 commits into from
Jun 26, 2020

Conversation

JeffreyThiessen
Copy link
Member

@JeffreyThiessen JeffreyThiessen commented Mar 31, 2020 •
edited
Loading

Description of changes

Restructured some parser code to support deployment in cloud environments.
See solution B in #73

Related issue

Fixes #73

Checklist

  • CHANGELOG.md updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

JeffreyThiessen and others added 15 commits March 30, 2020 19:14
@JeffreyThiessen
moved csv_reader to a new common.py file to decrease dup code
06e5c02
@JeffreyThiessen
Moved directory finding code to common parser code
c4239cd
@JeffreyThiessen
Refactor miseq get_sequencing_run
7b52198
@JeffreyThiessen
cleanup whitespace pep8
249b530
@JeffreyThiessen
Change sample sheet error to directory error when dir does not exist
ee588f9
@JeffreyThiessen
Refactor miniseq parser for cloud support
35237a7
@JeffreyThiessen
add warning about cloud deployment to miseq parser
00aea45
@JeffreyThiessen
Merge branch 'development' of https://github.com/phac-nml/irida-uploader
5913c20 
 into cloud_parser_refactor
@JeffreyThiessen
fix miseq parser tests
b559e32
@JeffreyThiessen
cleanup empty test suite
29d23a4
@JeffreyThiessen
fix miniseq tests
013b759
@JeffreyThiessen
improved testing for common csv parser
398b504
@JeffreyThiessen
updated directory parser and tests for cloud deploy
885c93e
@JeffreyThiessen
added page on cloud deployment to dev docs
4cbdc9c
@JeffreyThiessen
Update version number and add to changelog
d453bf1
@JeffreyThiessen JeffreyThiessen marked this pull request as ready for review April 29, 2020 22:48
@JeffreyThiessen JeffreyThiessen mentioned this pull request Jun 15, 2020
Merged
3 tasks
@JeffreyThiessen JeffreyThiessen requested a review from tom114 June 19, 2020 16:04
tom114
tom114 suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@tom114 tom114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for these changes. Just a couple commenting additions.

tom114
tom114 suggested changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@tom114 tom114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo then i think it's good to go!

@tom114 tom114 merged commit 8420f35 into development Jun 26, 2020
@JeffreyThiessen JeffreyThiessen deleted the cloud_parser_refactor branch June 26, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom114 tom114 tom114 approved these changes

Assignees

@tom114 tom114

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify parser code flow to support cloud deployment
2 participants
@JeffreyThiessen @tom114