[CompileGuard] Fix compile guard select key parsing #1292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1292 +/- ##
==========================================
+ Coverage 85.83% 85.85% +0.01%
==========================================
Files 164 164
Lines 17544 17544
==========================================
+ Hits 15059 15062 +3
+ Misses 2485 2482 -3
|
See #1291. Fixes two-key case (previously unsupported), and adds and refactors tests.
rsetaluri
force-pushed
the
compile-guard-fix-two-key-case
branch
from
dc5c244
to
40684b9
Compare
|
Closing in favor of #1294 which should encapsulate all fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1291. Fixes two-key case (previously unsupported), and adds and refactors tests.