Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDArray] Update order to match numpy #1354

Merged
merged 18 commits into from
Jan 30, 2024
Merged

[NDArray] Update order to match numpy #1354

merged 18 commits into from
Jan 30, 2024

Conversation

leonardt
Copy link
Collaborator

Addresses #1310

cc @rkshthrmsh

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ed03f44) 85.24% compared to head (67d3c7f) 85.22%.
Report is 4 commits behind head on master.

❗ Current head 67d3c7f differs from pull request most recent head 14f121a. Consider uploading reports for the commit 14f121a to get more accurate results

Files Patch % Lines
magma/primitives/set_index.py 80.00% 3 Missing ⚠️
magma/array.py 92.30% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   85.24%   85.22%   -0.02%     
==========================================
  Files         169      169              
  Lines       17617    17624       +7     
==========================================
+ Hits        15017    15020       +3     
- Misses       2600     2604       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from nd-set-index to master January 29, 2024 22:54
@leonardt leonardt merged commit 8d68a6c into master Jan 30, 2024
4 checks passed
@leonardt leonardt deleted the nd-array-order branch January 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants