Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rstudio bash script #137

Merged
merged 9 commits into from
Sep 21, 2023
Merged

add rstudio bash script #137

merged 9 commits into from
Sep 21, 2023

Conversation

dgrassellyb
Copy link
Collaborator

No description provided.

@dgrassellyb dgrassellyb requested a review from galachad August 4, 2023 08:11
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
admiralci 0% ❌
Summary 0% (0 / 22) ❌

galachad
galachad requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@galachad galachad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the script as simple as possible.

.devcontainer/postCreateCommand.sh Outdated Show resolved Hide resolved
.devcontainer/rstudio.sh Outdated

# Get rstudio url and open it
url=$(jq -r ".CODESPACE_NAME" /workspaces/.codespaces/shared/environment-variables.json)
url_rstudio="https://$url-8787.app.github.dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url is not possible to reach without gitlab auth.

I will propose to keep it simple.

$BROWSER "https://${CODESPACE_NAME}-8787.${GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN}"

If you would like to check if rstudio is stareted we should query http://localhost:8787.

.devcontainer/postCreateCommand.sh Outdated Show resolved Hide resolved
galachad
galachad reviewed Aug 9, 2023
View reviewed changes
.devcontainer/rstudio.sh Outdated Show resolved Hide resolved
@galachad
Copy link
Member

Hi @dgrassellyb could you take a look on comments?

@dgrassellyb
Copy link
Collaborator Author

Hi @dgrassellyb could you take a look on comments?

Hi @galachad this one is quite outdated, it's a bit duplicate on what you did for codespaces
for example you're already doing this command in postAttachCommand "postAttachCommand": "$BROWSER \"https://${CODESPACE_NAME}-8787.${GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN}/\"",

I see you suggested to delete the part waiting rstudio server to be ready (rstudio.sh script) - so I guess we can just close this PR

@galachad galachad marked this pull request as ready for review September 21, 2023 20:47
@galachad galachad requested a review from cicdguy as a code owner September 21, 2023 20:47
galachad
galachad approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@galachad galachad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to have the rstudio command in the console.

I'm merging this PR.

@galachad galachad merged commit 25d9afb into main Sep 21, 2023
@galachad galachad deleted the update_rstudio_bash_script branch September 21, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galachad galachad galachad approved these changes

@cicdguy cicdguy Awaiting requested review from cicdguy cicdguy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgrassellyb @galachad @pharmaverse-bot