Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner: add armv8r52-mps3an536-qemu target #366

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

trunner: add armv8r52-mps3an536-qemu target #366

wants to merge 2 commits into from

Conversation

adamdebek
Copy link
Contributor

JIRA: CI-468

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • [] Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   37m 47s ⏱️ +3s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 413a7c8. ± Comparison against base commit a20b474.

♻️ This comment has been updated with latest results.

mateusz-bloch
mateusz-bloch reviewed Aug 19, 2024
View reviewed changes
trunner/target/emulated.py
Comment on lines +101 to +102
rootfs = False

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If most of the tests haven't been run yet, and if we only want to run specific ones for now, I would assume for example, psh tests, I would set experimental to True and "include" the given target in given test yaml.

Suggested change
rootfs = False
rootfs = False
experimental = True

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, as I mentioned, all tests are currently being run, but the binaries are not present on the system.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the suggestion, we should set is as experimental for now and enable only psh tests (in yaml)

trunner/target/emulated.py
@@ -94,3 +94,15 @@ def __init__(self):
@classmethod
def from_context(cls, _: TestContext):
return cls()


class ARMv8R52_MPS3_AN536QemuTarget(QemuTarget):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, we don't use _ in other target class names. I would stick to one consistent naming convention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamdebek please apply the suggestion

mateusz-bloch
mateusz-bloch requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also every exit currently ends with an Abort. Is issue was reported? If the fix might take some time, you could add a workaround to run tests earlier.

image

Edit:
There are also a few issues where the OS freezes after certain commands
image

@lukileczo
Copy link
Member

lukileczo commented Aug 28, 2024 •
edited
Loading

Also every exit currently ends with an Abort. Is issue was reported? If the fix might take some time, you could add a workaround to run tests earlier.

@mateusz-bloch I'm aware of this issue, it's related to toolchain - I've found the root cause but now have no time to try to fix it. I will get back to it. Also: any application will fail on exit - so no point in running other tests on this target now.

damianloew
damianloew requested changes Sep 17, 2024
View reviewed changes
trunner/target/emulated.py
@@ -94,3 +94,15 @@ def __init__(self):
@classmethod
def from_context(cls, _: TestContext):
return cls()


class ARMv8R52_MPS3_AN536QemuTarget(QemuTarget):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamdebek please apply the suggestion

trunner/target/emulated.py
Comment on lines +101 to +102
rootfs = False

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the suggestion, we should set is as experimental for now and enable only psh tests (in yaml)

@damianloew damianloew mentioned this pull request Sep 18, 2024
Open
14 tasks
damianloew
damianloew reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable this target to CI in a separate commit

mateusz-bloch
mateusz-bloch reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to resolution of issue #1171, you can check if psh tests are works correctly now

damianloew
damianloew reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue that was stopping these changes have been fixed, please prepare it to merge - apply the suggestions and run CI on this target on PR in phoenix-rtos-project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew requested changes

@mateusz-bloch mateusz-bloch mateusz-bloch requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamdebek @lukileczo @damianloew @mateusz-bloch