-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Spock to JUnit migration #1249
Open
php-coder
wants to merge
14
commits into
master
Choose a base branch
from
gh1246_junit_migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The renaming is required as tests on Java and Groovy can't have the same class names. The original names (without Legacy prefix) will be used by new tests on Java. Part of 1246
This change is needed in order to simplify automated porting of tests. Part of 1246
This change is needed in order to simplify automated porting of tests. Part of 1246
This change is needed in order to simplify automated porting of tests. Part of 1246
This change is needed in order to simplify automated porting of tests. Part of 1246
This change is needed in order to simplify automated porting of tests. Part of 1246
This change is needed in order to simplify automated porting of tests. Part of 1246
… code. This change is needed in order to simplify automated porting of tests. Part of 1246
php-coder
force-pushed
the
gh1246_junit_migration
branch
from
January 28, 2020 00:06
86fb6af
to
a49c37e
Compare
This change is needed in order to simplify automated porting of tests. Part of 1246
We use it in ru.mystamps.web.feature.account.LegacyUserServiceImplTest and it's not clear how it worked before. This change is needed in order to simplify automated porting of tests. Part of 1246
…diate local variable.
This change is needed in order to simplify automated porting of tests. Part of 1246
php-coder
force-pushed
the
gh1246_junit_migration
branch
from
January 28, 2020 00:26
a49c37e
to
65d62d8
Compare
… it. This change is needed in order to simplify automated porting of tests. Part of 1246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not forget:
Address to #1246