Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Spock to JUnit migration #1249

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Spock to JUnit migration #1249

wants to merge 14 commits into from

Conversation

php-coder
Copy link
Owner

@php-coder php-coder commented Jan 27, 2020 •
edited
Loading

To not forget:

  • remove WIP from title
  • remove "DO NOT MERGE" commit(s)
  • check/update links to the issue on commits

Address to #1246

@php-coder
refactor: rename tests on Groovy and add Legacy prefix to their names.
ad1bbf9 
The renaming is required as tests on Java and Groovy can't have the same class names. The original
names (without Legacy prefix) will be used by new tests on Java.

Part of 1246
@php-coder
refactor: rename methods to avoid escaping of a single quote.
6632676 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor: explicitly specify members type.
b2791d8 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor: split "where" block and its arguments
2cae593 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
style: add white spaces where needed and remove trailing tabs.
7408a66 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
[DO NOT MERGE] run only a single profile.
d93b668
@php-coder
refactor: propagate assertThat().isNotNull()
cab975b 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor: use assertThat() for hours/minutes/seconds/milliseconds.
4079d28 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor: use assertThat().isToday() and .isInSameDayAs() to simplify…
3b3bd49 
… code.

This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor: use getters explicitly.
fad9082 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor: make a constant be accessible in other packages.
1b23a09 
We use it in ru.mystamps.web.feature.account.LegacyUserServiceImplTest and it's not clear how it
worked before.

This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor(TestObjects.createUsersActivationFullDto): remove an interme…
f9c4357 
…diate local variable.
@php-coder
refactor: add explicit import for Date class.
65d62d8 
This change is needed in order to simplify automated porting of tests.

Part of 1246
@php-coder
refactor: don't call init() method on the interface that doesn't have…
0b5a2f7 
… it.

This change is needed in order to simplify automated porting of tests.

Part of 1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@php-coder