Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Spock to JUnit migration #1249

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Spock to JUnit migration #1249

wants to merge 14 commits into from

Commits on Jan 27, 2020

  1. refactor: rename tests on Groovy and add Legacy prefix to their names. 

    The renaming is required as tests on Java and Groovy can't have the same class names. The original
names (without Legacy prefix) will be used by new tests on Java.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    ad1bbf9 View commit details
    Browse the repository at this point in the history

  2. refactor: rename methods to avoid escaping of a single quote. 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    6632676 View commit details
    Browse the repository at this point in the history

  3. refactor: explicitly specify members type. 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    b2791d8 View commit details
    Browse the repository at this point in the history

  4. refactor: split "where" block and its arguments 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    2cae593 View commit details
    Browse the repository at this point in the history

  5. style: add white spaces where needed and remove trailing tabs. 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    7408a66 View commit details
    Browse the repository at this point in the history

  6. [DO NOT MERGE] run only a single profile.

    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    d93b668 View commit details
    Browse the repository at this point in the history

  7. refactor: propagate assertThat().isNotNull() 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    cab975b View commit details
    Browse the repository at this point in the history

  8. refactor: use assertThat() for hours/minutes/seconds/milliseconds. 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    4079d28 View commit details
    Browse the repository at this point in the history

  9. refactor: use assertThat().isToday() and .isInSameDayAs() to simplify… 

    … code.

This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    3b3bd49 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. refactor: use getters explicitly. 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    fad9082 View commit details
    Browse the repository at this point in the history

  2. refactor: make a constant be accessible in other packages. 

    We use it in ru.mystamps.web.feature.account.LegacyUserServiceImplTest and it's not clear how it
worked before.

This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    1b23a09 View commit details
    Browse the repository at this point in the history

  3. refactor(TestObjects.createUsersActivationFullDto): remove an interme… 

    …diate local variable.
    @php-coder
    php-coder committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    f9c4357 View commit details
    Browse the repository at this point in the history

  4. refactor: add explicit import for Date class. 

    This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    65d62d8 View commit details
    Browse the repository at this point in the history

  5. refactor: don't call init() method on the interface that doesn't have… 

    … it.

This change is needed in order to simplify automated porting of tests.

Part of 1246
    @php-coder
    php-coder committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    0b5a2f7 View commit details
    Browse the repository at this point in the history