remove default value on boolean node, add new dataset on ExtractorTest

php-etl · May 27, 2024 · de36c81 · de36c81
1 parent 320bdd5
commit de36c81
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/src/Builder/Capacity/Lookup/All.php b/src/Builder/Capacity/Lookup/All.php
@@ -15,10 +15,6 @@ final class All implements Builder
     private ?Node\Expr $code = null;
     private string $type = '';
 
-    public function __construct()
-    {
-    }
-
     public function withEndpoint(Node\Expr|Node\Identifier $endpoint): self
     {
         $this->endpoint = $endpoint;

diff --git a/src/Configuration/Extractor.php b/src/Configuration/Extractor.php
@@ -239,7 +239,6 @@ public function getConfigTreeBuilder(): Config\Definition\Builder\TreeBuilder
                     ->end()
                 ->end()
                 ->booleanNode('with_enriched_attributes')
-                    ->defaultFalse()
                     ->validate()
                         ->ifTrue(isExpression())
                         ->then(asExpression())

diff --git a/tests/functional/Configuration/ExtractorTest.php b/tests/functional/Configuration/ExtractorTest.php
@@ -82,6 +82,20 @@ public static function validDataProvider(): iterable
                 'search' => [],
             ],
         ];
+        yield [
+            'config' => [
+                'method' => 'all',
+                'type' => 'category',
+                'search' => [],
+                'with_enriched_attributes' => true,
+            ],
+            'expected' => [
+                'method' => 'all',
+                'type' => 'category',
+                'search' => [],
+                'with_enriched_attributes' => true,
+            ],
+        ];
     }
 
     #[\PHPUnit\Framework\Attributes\DataProvider('validDataProvider')]