[PHP 8.4] intl changes part 1. #4160
Conversation
|
for #3872 |
| @@ -156,6 +156,15 @@ | |||
| </row> | |||
| </thead> | |||
| <tbody> | |||
| <row> | |||
| <entry>8.4.0</entry> | |||
There was a problem hiding this comment.
Should also be in the error section of the page
| <entry>8.4.0</entry> | ||
| <entry> | ||
| <para> | ||
| A <classname>Value</classname> is thrown if |
There was a problem hiding this comment.
| A <classname>Value</classname> is thrown if | |
| A <exceptionname>ValueError</exceptionname> is thrown if |
There was a problem hiding this comment.
Not addressed yet (notice ValueError) and mistake copied in error section (check all places for this mistake)
| @@ -103,6 +103,15 @@ | |||
| </row> | |||
| </thead> | |||
| <tbody> | |||
| <row> | |||
There was a problem hiding this comment.
Same remarks as for dateformatter
| <row> | ||
| <entry>8.4.0</entry> | ||
| <entry> | ||
| <para> |
| <row> | ||
| <entry>8.4.0</entry> | ||
| <entry> | ||
| <para> |
There was a problem hiding this comment.
simpara please
Also add this to the error section of the page
| <entry>8.4.0</entry> | ||
| <entry> | ||
| <para> | ||
| A <classname>TypeError</classname> is thrown if |
There was a problem hiding this comment.
Use exceptionname instead of classname in these descriptions
devnexen
force-pushed
the
intl_upd_84
branch
from
62ec8e9 to
2ae2c30
Compare
| @@ -73,6 +72,52 @@ | |||
| </para> | |||
| </refsect1> | |||
|
|
|||
| <refsect1 role="errors"> | |||
| &reftitle.errors; | |||
| <para> | |||
There was a problem hiding this comment.
I think we usually use an itemizedlist for multiple errors, also: simpara. But I'll divert to @Girgias for the markup details
There was a problem hiding this comment.
I don't think we have a consistent style tbh, I have used multiple <simpara> tags in general. But I don't mind either style.
| <para> | ||
| A <exceptionname>ValueError</exceptionname> is thrown if | ||
| <parameter>locale</parameter> is invalid. | ||
| </para> |
There was a problem hiding this comment.
| <para> | |
| A <exceptionname>ValueError</exceptionname> is thrown if | |
| <parameter>locale</parameter> is invalid. | |
| </para> | |
| <simpara> | |
| A <exceptionname>ValueError</exceptionname> is thrown if | |
| <parameter>locale</parameter> is invalid. | |
| </simpara> |
| <para> | ||
| A <exceptionname>ValueError</exceptionname> is thrown if | ||
| <parameter>locale</parameter> is invalid. | ||
| </para> |
There was a problem hiding this comment.
| <para> | |
| A <exceptionname>ValueError</exceptionname> is thrown if | |
| <parameter>locale</parameter> is invalid. | |
| </para> | |
| <simpara> | |
| A <exceptionname>ValueError</exceptionname> is thrown if | |
| <parameter>locale</parameter> is invalid. | |
| </simpara> |
| @@ -73,6 +72,52 @@ | |||
| </para> | |||
| </refsect1> | |||
|
|
|||
| <refsect1 role="errors"> | |||
| &reftitle.errors; | |||
| <para> | |||
There was a problem hiding this comment.
I don't think we have a consistent style tbh, I have used multiple <simpara> tags in general. But I don't mind either style.
| &reftitle.changelog; | ||
| <para> | ||
| <informaltable> |
There was a problem hiding this comment.
The wrapping <para> tag here is useless.
| </refsect1> | ||
|
|
||
|
|
||
| <refsect1 role="examples"> |
There was a problem hiding this comment.
Nit:
| </refsect1> | |
| <refsect1 role="examples"> | |
| </refsect1> | |
| <refsect1 role="examples"> |
devnexen
force-pushed
the
intl_upd_84
branch
from
643d7ad to
91f5df2
Compare
No description provided.