Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] intl changes part 1. #4160

Merged
merged 4 commits into from
Nov 28, 2024
+77 −1
Merged

[PHP 8.4] intl changes part 1. #4160

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4316ab7
[PHP 8.4] intl changes.
devnexen Nov 26, 2024
2ae2c30
changes from feedback
devnexen Nov 26, 2024
91f5df2
changes from review
devnexen Nov 27, 2024
20ab226
Nit
Girgias Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions reference/intl/dateformatter/create.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,15 @@
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be in the error section of the page

<entry>
<para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use simpara

A <classname>Value</classname> is thrown if
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A <classname>Value</classname> is thrown if
A <exceptionname>ValueError</exceptionname> is thrown if

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not addressed yet (notice ValueError) and mistake copied in error section (check all places for this mistake)

<parameter>locale</parameter> is invalid.
</para>
</entry>
</row>
<row>
<entry>8.1.0</entry>
<entry>
Expand Down
9 changes: 9 additions & 0 deletions reference/intl/numberformatter/create.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,15 @@
</row>
</thead>
<tbody>
<row>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks as for dateformatter

<entry>8.4.0</entry>
<entry>
<para>
A <classname>Value</classname> is thrown if
<parameter>locale</parameter> is invalid.
</para>
</entry>
</row>
<row>
<entry>8.0.0</entry>
<entry>
Expand Down
33 changes: 32 additions & 1 deletion reference/intl/resourcebundle/get.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
</para>
</refsect1>


<refsect1 role="returnvalues">
&reftitle.returnvalues;
<para>
Expand All @@ -73,6 +72,38 @@
</para>
</refsect1>

<refsect1 role="changelog">
&reftitle.changelog;
<para>
<informaltable>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapping <para> tag here is useless.

<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
<entry>
<para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpara please
Also add this to the error section of the page

A <classname>TypeError</classname> is thrown if
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use exceptionname instead of classname in these descriptions

the offset type is invalid.
A <classname>ValueError</classname> is thrown if
if <parameter>index</parameter> is a <type>string</type>
and is empty or is a <type>int</type> and does not
fit into a 32 bit integer type.
</para>
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</para>
</refsect1>


<refsect1 role="examples">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
</refsect1>
<refsect1 role="examples">
</refsect1>
<refsect1 role="examples">

&reftitle.examples;
<example>
Expand Down