Enhancement: Run end-to-end tests asserting an HTTP response status code #900
Conversation
|
🚀 Commit d8fdb48 Deployed on https://web-php-pr-900.preview.thephp.foundation |
tests/server
Outdated
There was a problem hiding this comment.
I copied this file from https://github.com/cubny/php-built-in-server-manager/blob/9a5cbeaad50a108d6058b882b83ba23fbd7722a9/server.
If someone wants to write their own, I'll be happy to copy it.
localheinz
force-pushed
the
feature/end-to-end
branch
from
890ac82 to
0ba2609
Compare
|
🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation |
tests/EndToEnd/ChangeLog-4.php-returns-http-response-status-code-200.phpt
Outdated
Show resolved
Hide resolved
localheinz
force-pushed
the
feature/end-to-end
branch
from
0ba2609 to
25bc229
Compare
|
🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation |
localheinz
force-pushed
the
feature/end-to-end
branch
from
25bc229 to
bd9fde7
Compare
|
🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation |
localheinz
force-pushed
the
feature/end-to-end
branch
from
bd9fde7 to
ba9eb8e
Compare
|
🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation |
localheinz
force-pushed
the
feature/end-to-end
branch
from
ba9eb8e to
5daaceb
Compare
|
🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation |
|
@localheinz I tried adding |
localheinz
force-pushed
the
feature/end-to-end
branch
from
5daaceb to
4cf1099
Compare
With 48a8881 and running php -S localhost:8080 .router.phpI can see the following output in the console: [Fri Dec 22 15:21:47 2023] [::1]:49172 Accepted
[Fri Dec 22 15:21:47 2023] PHP Fatal error: Message in /Users/am/Sites/php/web-php/search.php on line 12
[Fri Dec 22 15:21:47 2023] [::1]:49172 [200]: GET /search.php?show=quickref&pattern= - Message in /Users/am/Sites/php/web-php/search.php on line 12
[Fri Dec 22 15:21:47 2023] [::1]:49172 Closing
[Fri Dec 22 15:21:47 2023] [::1]:49173 Accepted
[Fri Dec 22 15:21:47 2023] [::1]:49173 [200]: GET /favicon.ico
[Fri Dec 22 15:21:47 2023] [::1]:49173 ClosingWith 48a8881, the tests fail on GitHub Actions, see https://github.com/php/web-php/actions/runs/7300886487/job/19896408958?pr=900. I do not know why they pass locally and fail on GitHub Actions, but I assume it has something to do with the configuration of PHP. |
localheinz
force-pushed
the
feature/end-to-end
branch
3 times, most recently
from
a2a8c42 to
30c8014
Compare
| @@ -0,0 +1,3 @@ | |||
| [PHP] | |||
|
|
|||
| display_errors = Off | |||
There was a problem hiding this comment.
According to https://stackoverflow.com/a/28974224/1172545, this should help!
localheinz
force-pushed
the
feature/end-to-end
branch
from
30c8014 to
817e6dc
Compare
|
@localheinz with the php.ini it works now 🙏 |
localheinz
force-pushed
the
feature/end-to-end
branch
4 times, most recently
from
57f79e0 to
a18982f
Compare
localheinz
force-pushed
the
feature/end-to-end
branch
from
a18982f to
5fd7ef4
Compare
localheinz
force-pushed
the
feature/end-to-end
branch
from
5fd7ef4 to
16904cc
Compare
|
Thank you, @pronskiy, @saundefined, and @sy-records! |
This pull request
Also see #605.