Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize context menu #880

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from
Open

Finalize context menu #880

wants to merge 3 commits into from

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Jan 17, 2025

Followup to: #869
Blocked by: pimcore/studio-backend-bundle#700

Additional info

This pull request includes significant updates to the asset API slice and the use-clear-thumbnails hook in the Pimcore project. The changes primarily focus on refactoring the code to improve clarity and maintainability.

Key changes include:

Refactoring API Endpoints:

  • Replaced the useAssetImageClearThumbnailMutation with useAssetClearThumbnailMutation in use-clear-thumbnails.tsx and updated the corresponding import statements. [1] [2]
  • Removed the assetImageClearThumbnail mutation and added the assetClearThumbnail mutation in asset-api-slice.gen.ts. This change updates the endpoint for clearing thumbnails. [1] [2]

Type Adjustments:

  • Updated various types to use any instead of nullable types (e.g., number | null to any) in asset-api-slice.gen.ts. This change affects multiple type definitions, including AssetUpdateByIdApiArg, AssetPatchByIdApiArg, AssetPatchFolderByIdApiArg, Element, CustomAttributes, and others. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]

Code Cleanup:

  • Removed unused mutation useAssetImageClearThumbnailMutation from the export list and added useAssetClearThumbnailMutation in asset-api-slice.gen.ts.

These changes streamline the code and improve the consistency of type usage across the asset API slice, making the codebase easier to maintain and extend in the future.

@Corepex Corepex self-assigned this Jan 17, 2025
Copy link

sonarqubecloud bot commented Jan 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
19.3% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants