Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize context menu #880

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from
Open

Finalize context menu #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e61ef85
added correct icon
Corepex Jan 17, 2025
6d02ed4
implemented new endpoint for clearing thumbnails
Corepex Jan 17, 2025
efa0e11
Apply latest automatic api client updates
Corepex Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/build/api/docs.jsonopenapi.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/js/src/core/assets/icons/remove-pdf-thumbnail.inline.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions assets/js/src/core/modules/app/settings/settings-slice.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,19 @@ export type SystemSettingsGetApiResponse = /** status 200 System settings data *
export type SystemSettingsGetApiArg = void;
export type FixedCustomSettings = {
/** embedded meta data of the asset - array of any key-value pairs */
embeddedMetadata: any[];
embeddedMetadata: object[];
/** flag to indicate if the embedded meta data has been extracted from the asset */
embeddedMetadataExtracted: boolean;
};
export type CustomSettings = {
/** AdditionalAttributes */
additionalAttributes?: {
[key: string]: string | number | boolean | object | any[];
[key: string]: string | number | boolean | object;
};
/** fixed custom settings */
fixedCustomSettings?: FixedCustomSettings | null;
/** dynamic custom settings - can be any key-value pair */
dynamicCustomSettings?: any[];
dynamicCustomSettings?: object[];
};
export type Error = {
/** Message */
Expand Down
6 changes: 4 additions & 2 deletions assets/js/src/core/modules/asset/actions/clear-thumbnails/use-clear-thumbnails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
*/

import { type ItemType } from '@Pimcore/components/dropdown/dropdown'
import { type Asset, useAssetImageClearThumbnailMutation } from '@Pimcore/modules/asset/asset-api-slice.gen'
import {
type Asset, useAssetClearThumbnailMutation
} from '@Pimcore/modules/asset/asset-api-slice.gen'
import { Icon } from '@Pimcore/components/icon/icon'
import React from 'react'
import { useTranslation } from 'react-i18next'
Expand All @@ -26,7 +28,7 @@ export interface UseClearThumbnailsHookReturn {

export const useClearThumbnails = (): UseClearThumbnailsHookReturn => {
const { t } = useTranslation()
const [clearThumbnail] = useAssetImageClearThumbnailMutation()
const [clearThumbnail] = useAssetClearThumbnailMutation()

const handleClearThumbnails = async (node: Asset, onFinish?: () => void): Promise<void> => {
const clearThumbnailTask = clearThumbnail({ id: node.id })
Expand Down
Loading